Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time.interest to reduce unique time points #700

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Add time.interest to reduce unique time points #700

merged 5 commits into from
Nov 7, 2023

Conversation

mnwright
Copy link
Member

@mnwright mnwright commented Nov 3, 2023

Fixes #410.

@mnwright mnwright mentioned this pull request Nov 3, 2023
Merged
@jemus42
Copy link
Contributor

jemus42 commented Nov 3, 2023

If time.interest can be

  • A vector of time points to evaluate on
  • A scalar denoting the number of unique time points to evaluate on

Doesn't that mean that the user might be interested in just a single time point time.interest = 42 (e.g. median observed event time) and specify that, expecting evaluation on a single time point t = 42 but receiving, well, more?

@mnwright mnwright merged commit 4ce5894 into master Nov 7, 2023
8 checks passed
@mnwright mnwright deleted the restrict_timepoints branch November 7, 2023 19:27
@mnwright mnwright mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add restriction for unique.death.times
2 participants
@mnwright @jemus42